Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix translations #40

Merged
merged 6 commits into from Jun 4, 2019
Merged

Fix translations #40

merged 6 commits into from Jun 4, 2019

Conversation

klzns
Copy link
Contributor

@klzns klzns commented May 14, 2019

What is the purpose of this pull request?

Fix English translation and some chores.

What problem is this solving?

English translation.

How should this be manually tested?

https://breno--storecomponents.myvtexdev.com/shirt/p

Screenshots or example usage

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@jgfidelis jgfidelis merged commit e86ecbb into master Jun 4, 2019
@jgfidelis jgfidelis deleted the fix/translations branch June 4, 2019 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matheusps matheusps matheusps approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@klzns @matheusps @jgfidelis