Merge pull request #149 from vtex-apps/fix/product-null

Fix product image product evaluation (console errors)
vtex-apps · Apr 30, 2019 · bae2216 · bae2216
2 parents 21feed1 + 86edb68
commit bae2216
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
+## [2.19.2] - 2019-04-30
+### Fixed
+- Fix `ProductImage` product evaluation.
+
 ## [2.19.1] - 2019-04-30
 ### Fixed
 - Do not render `ProductPrice` when selling price is zero.

diff --git a/manifest.json b/manifest.json
@@ -1,7 +1,7 @@
 {
   "vendor": "vtex",
   "name": "product-summary",
-  "version": "2.19.1",
+  "version": "2.19.2",
   "title": "Product Summary",
   "description": "Product summary component",
   "defaultLocale": "pt-BR",

diff --git a/react/legacy/components/ProductImage.js b/react/legacy/components/ProductImage.js
@@ -39,6 +39,10 @@ const ProductImage = ({
   showCollections,
   displayMode,
 }) => {
+  if (!path(['sku', 'image', 'imageUrl'], product)) {
+    return <ImagePlaceholder />
+  }
+
   const {
     productClusters,
     productName: name,
@@ -47,10 +51,6 @@ const ProductImage = ({
     },
   } = product
 
-  if (!path(['sku', 'image', 'imageUrl'], product)) {
-    return <ImagePlaceholder />
-  }
-
   const imageClassName = classNames({
     [productSummary.imageNormal]: displayMode !== 'inline',
     [productSummary.imageInline]: displayMode === 'inline',