Refactor sort function

vtex-apps · May 23, 2019 · f4d3695 · f4d3695
1 parent 33f72e9
commit f4d3695
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 15 deletions.
diff --git a/react/components/ProductSummaryPrice/ProductSummaryPrice.js b/react/components/ProductSummaryPrice/ProductSummaryPrice.js
@@ -5,7 +5,9 @@ import {
   prop,
   flatten,
   map,
-  filter
+  filter,
+  head,
+  last
 } from 'ramda'
 import classNames from 'classnames'
 import { Spinner } from 'vtex.styleguide'
@@ -15,14 +17,11 @@ import ProductSummaryContext from '../ProductSummaryContext'
 import { productShape } from '../../utils/propTypes'
 import productSummary from '../../productSummary.css'
 
-const sortPrices = (priceA, priceB) => priceA - priceB
-const lowestPrice = compose(head, sort(sortPrices))
-const highestPrice = compose(last, sort(sortPrices))
-
 const isAvailableProduct = price => price !== 0
 const getListPrices = prices => {
-  const lowPrice = lowestPrice(prices)
-  const highPrice = highestPrice(prices)
+  const sortPrices = prices.sort()
+  const lowPrice = head(sortPrices)
+  const highPrice = last(sortPrices)
   return [
     lowPrice,
     highPrice,

diff --git a/react/legacy/components/ProductSummaryPrice.js b/react/legacy/components/ProductSummaryPrice.js
@@ -6,8 +6,6 @@ import {
   flatten,
   map,
   filter,
-  sort,
-  compose,
   head,
   last
 } from 'ramda'
@@ -16,14 +14,11 @@ import { ProductPrice } from 'vtex.store-components'
 
 import { productShape } from '../../utils/propTypes'
 
-const sortPrices = (priceA, priceB) => priceA - priceB
-const lowestPrice = compose(head, sort(sortPrices))
-const highestPrice = compose(last, sort(sortPrices))
-
 const isAvailableProduct = price => price !== 0
 const getListPrices = prices => {
-  const lowPrice = lowestPrice(prices)
-  const highPrice = highestPrice(prices)
+  const sortPrices = prices.sort()
+  const lowPrice = head(sortPrices)
+  const highPrice = last(sortPrices)
   return [
     lowPrice,
     highPrice,