Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add labelListPrice prop in ProductSummaryPrice #156

Merged
merged 4 commits into from
May 21, 2019
Merged

Add labelListPrice prop in ProductSummaryPrice #156

merged 4 commits into from
May 21, 2019

Conversation

thayannevls
Copy link
Contributor

What is the purpose of this pull request?

Add labelListPrice on the productSummaryPrice and pass the prop to the ProductPrice.

What problem is this solving?

Discount price labels should be flexible.

How should this be manually tested?

Workspace

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@lucis
Copy link
Contributor

lucis commented May 21, 2019

Update docs

@lucis lucis merged commit a615252 into master May 21, 2019
@lucis lucis deleted the fix/price-labels-not-showing branch May 21, 2019 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rerissondaniel rerissondaniel rerissondaniel approved these changes

@lucis lucis lucis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thayannevls @lucis @rerissondaniel