Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show price range on product summary #157

Merged
merged 30 commits into from May 28, 2019
Merged

Show price range on product summary #157

merged 30 commits into from May 28, 2019

Conversation

fanny
Copy link
Member

@fanny fanny commented May 21, 2019 •
edited

What is the purpose of this pull request?

as the title says.

What problem is this solving?

https://app.clubhouse.io/vtex-dev/story/11402/show-price-range-on-product-summary

How should this be manually tested?

  1. Acess this workspace
  2. Check if an product that have an price range shows the new prop

Screenshots or example usage

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@fanny fanny changed the title Feat/add range of prices Show price range on product summary May 21, 2019
@fanny fanny marked this pull request as ready for review May 21, 2019 18:47
jgfidelis
jgfidelis suggested changes May 21, 2019
View reviewed changes
Copy link
Contributor

@jgfidelis jgfidelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing showPriceRange prop in this component schema

lucis
lucis reviewed May 22, 2019
View reviewed changes
Copy link
Contributor

@lucis lucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the docs (.MD)

react/components/ProductSummaryPrice/ProductSummaryPrice.js Outdated Show resolved Hide resolved
react/components/ProductSummaryPrice/ProductSummaryPrice.js Outdated Show resolved Hide resolved
react/components/ProductSummaryPrice/ProductSummaryPrice.js Outdated Show resolved Hide resolved
react/components/ProductSummaryPrice/ProductSummaryPrice.js Outdated Show resolved Hide resolved
@fanny fanny force-pushed the feat/add-range-of-prices branch from bd98b2a to 9adb417 Compare May 24, 2019 13:51
jgfidelis
jgfidelis suggested changes May 25, 2019
View reviewed changes
Copy link
Contributor

@jgfidelis jgfidelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont merge this

@jgfidelis jgfidelis merged commit b311304 into master May 28, 2019
@jgfidelis jgfidelis deleted the feat/add-range-of-prices branch May 28, 2019 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucis lucis lucis left review comments

@jgfidelis jgfidelis jgfidelis approved these changes

@matheusps matheusps matheusps approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fanny @jgfidelis @matheusps @lucis