Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing interface to handle Wishlist button when using product-summary.shelf #164

Merged
merged 2 commits into from Jun 10, 2019
Merged

Added missing interface to handle Wishlist button when using product-summary.shelf #164

merged 2 commits into from Jun 10, 2019

Conversation

klzns
Copy link
Contributor

@klzns klzns commented Jun 10, 2019

What is the purpose of this pull request?

Handle wishlist in destructured version of product-summary.

What problem is this solving?

Wishlist would appear at the bottom of the product-summary.

How should this be manually tested?

https://breno--storecomponents.myvtexdev.com/decoration

Screenshots or example usage

Before After
image image

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@klzns klzns mentioned this pull request Jun 10, 2019
Merged
4 tasks
@klzns klzns merged commit e552076 into master Jun 10, 2019
@klzns klzns deleted the fix/wishlist branch June 10, 2019 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinch kevinch kevinch approved these changes

@jgfidelis jgfidelis jgfidelis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@klzns @kevinch @jgfidelis