Add prop to show loading state #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
thayannevls
approved these changes
Jun 17, 2019
jgfidelis
approved these changes
Jun 18, 2019
|
Will the image have this |
estacioneto
approved these changes
Jun 18, 2019
lucasecdb
force-pushed
the
feat/loading-local
branch
2 times, most recently
from
e04f12d
to
b80d879
Compare
|
Your PR has been merged! App is being published. 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Add a
isPartialprop to show a loading state on the product, for when it's only locally persisted in the minicart.What problem is this solving?
Before, we had no visual indication that the item was only locally persisted or not.
How should this be manually tested?
workspace.
Types of changes