Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ProductSummaryBrand component #179

Merged
merged 1 commit into from
Aug 20, 2019
Merged

Added ProductSummaryBrand component #179

merged 1 commit into from
Aug 20, 2019

Conversation

iaronaraujo
Copy link
Contributor

What is the purpose of this pull request?

Make it possible to have a brand in the product summary. Depends on vtex-apps/store-components#555 to work properly

How should this be manually tested?

Workspace

Screenshots or example usage

image

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@iaronaraujo iaronaraujo requested a review from a team August 20, 2019 20:16
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Aug 20, 2019

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch

  • Minor

  • Major

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@iaronaraujo iaronaraujo merged commit ee234b9 into master Aug 20, 2019
@iaronaraujo iaronaraujo deleted the feature/brand branch August 20, 2019 20:37
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Aug 20, 2019

Your PR has been merged! App is being published. 🚀
Version 2.32.2 → 2.33.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants