Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customToastURL prop to ProductSummaryBuyButton #187

Merged
merged 3 commits into from
Sep 19, 2019

Conversation

victorhmp
Copy link
Contributor

What is the purpose of this pull request?

Add the same new prop being added to the BuyButton component from vtex.store-components. This should enable users to customize the URL linked to the Toast rendered by BuyButton.

What problem is this solving?

Enabling users to customize the URL.

How should this be manually tested?

Add an item from the Shelf here and click on the toast link, you should be taken to https://google.com

https://minicarttoast--storecomponents.myvtex.com/

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@victorhmp victorhmp self-assigned this Sep 18, 2019
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Sep 18, 2019

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch

  • Minor

  • Major

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@victorhmp victorhmp added the enhancement New feature or request label Sep 18, 2019
@victorhmp victorhmp merged commit 74a95a1 into master Sep 19, 2019
@victorhmp victorhmp deleted the feature/buyButton-customToastURL-prop branch September 19, 2019 18:25
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Sep 19, 2019

Your PR has been merged! App is being published. 🚀
Version 2.34.5 → 2.35.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants