New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/image size #190
Feature/image size #190
Conversation
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
Beep boop 🤖 Thank you so much for keeping our documentation up-to-date ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix unit tests
@@ -193,6 +232,8 @@ ProductImage.propTypes = { | |||
/** Display mode of the summary */ | |||
displayMode: PropTypes.oneOf(['normal', 'inline']), | |||
hoverImageLabel: PropTypes.string, | |||
width: PropTypes.number, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add object type as well
3e2cc3e
to
4f68b09
Compare
Your PR has been merged! App is being published. 🚀 |
What is the purpose of this pull request?
Adds
width
andheight
props to ProductImage.Also adds css handles (to ProductImage).
What problem is this solving?
How should this be manually tested?
https://lbebber--storecomponents.myvtex.com/
Look at the first shelf, and confirm that the size is set as follows:
(it takes into consideration the device's pixel density, so the image size might be twice or more depending on your screen, but the element itself should conform to these dimensions)
Screenshots or example usage
Types of changes