Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/image placeholder #194

Merged
merged 2 commits into from
Oct 15, 2019
Merged

Fix/image placeholder #194

merged 2 commits into from
Oct 15, 2019

Conversation

lbebber
Copy link
Contributor

@lbebber lbebber commented Oct 14, 2019

What is the purpose of this pull request?

Adds back ImagePlaceholder to flexible product-summary-image

What problem is this solving?

How should this be manually tested?

Before:
Screen Shot 2019-10-14 at 14 46 25

https://www.als.com/clothing/pants/Womens?map=c,c,specificationFilter_7721&page=5

After:
Screen Shot 2019-10-14 at 14 45 53

https://lbebber--alssports.myvtex.com/clothing/pants/Womens?map=c,c,specificationFilter_7721&page=5

Screenshots or example usage

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Oct 14, 2019

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch

  • Minor

  • Major

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Oct 14, 2019

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@lbebber lbebber requested a review from a team October 14, 2019 17:50
@lbebber lbebber mentioned this pull request Oct 14, 2019
4 tasks
@lbebber lbebber merged commit 2bae619 into master Oct 15, 2019
@lbebber lbebber deleted the fix/image-placeholder branch October 15, 2019 14:23
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Oct 15, 2019

Your PR has been merged! App is being published. 🚀
Version 2.37.1 → 2.37.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants