Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a max-width for the ProductSummary component #197

Merged
merged 3 commits into from Oct 17, 2019
Merged

Conversation

victorhmp
Copy link
Contributor

What is the purpose of this pull request?

Limit the max-width of a ProductSummary component.

What problem is this solving?

Prevents ProductSummary from being stretched even though the content would not fill it up.

How should this be manually tested?

https://productsummarywidth--storecomponents.myvtex.com/apparel---accessories
(Apply some filters to see what it looks like with less items)

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@victorhmp victorhmp self-assigned this Oct 17, 2019
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Oct 17, 2019

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch

  • Minor

  • Major

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Oct 17, 2019

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@victorhmp victorhmp requested review from lbebber, iaronaraujo, Klynger and a team October 17, 2019 17:26
@victorhmp
Copy link
Contributor Author

victorhmp commented Oct 17, 2019

I did not make this a prop just because it could lead to bad UX. The max-width for the content inside of a ProductSummary for some reason is always ~280px, so if a user were to set any value above 280px, it would do nothing. I also don't think it would be a good idea to make it smaller for some reason since you can always control the number of product-summary components you can show

react/components/ProductSummary.js Outdated Show resolved Hide resolved
Co-Authored-By: Rafael Klynger <rafael.dantas@vtex.com.br>
@victorhmp victorhmp merged commit ddde056 into master Oct 17, 2019
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Oct 17, 2019

Your PR has been merged! App is being published. 🚀
Version 2.37.2 → 2.37.3

@victorhmp victorhmp deleted the fix/max-width branch October 17, 2019 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants