Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow flex-layout and rich-text inside product-summary.shelf #215

Merged
merged 1 commit into from Nov 11, 2019

Conversation

klzns
Copy link
Contributor

@klzns klzns commented Nov 11, 2019

What is the purpose of this pull request?

Make the layout of product-summary more flexible.
Make it possible to add custom texts inside of product-summary.

What problem is this solving?

A store wanted to add a text before the brand name, example ("Por")

image

How should this be manually tested?

https://breno--storecomponents.myvtex.com/

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Nov 11, 2019

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch

  • Minor

  • Major

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Nov 11, 2019

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@klzns klzns requested review from a team and victorhmp November 11, 2019 22:49
@klzns klzns merged commit 52b09fb into master Nov 11, 2019
@klzns klzns deleted the feature/flex-rich branch November 11, 2019 22:52
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Nov 11, 2019

Your PR has been merged! App is being published. 🚀
Version 2.44.1 → 2.45.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants