Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fixed a bug where removing all items from review block would send the user to a nothing to show page #100

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

JooLuiz
Copy link
Contributor

@JooLuiz JooLuiz commented Feb 22, 2022

What does this PR do? *

Fixes the bug where removing all items from review block would send the user to a "nothing to show" page.

How to test it? *

Add item in the textAreaBlock and UploadBlock then remove each item, one by one, when removing the last item the user must go to the main page of the block, instead of to a page with the message "nothing to show"

Describe alternatives you've considered, if any. *

None

Related to / Depends on *

None

@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Feb 22, 2022

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@JooLuiz
Copy link
Contributor Author

JooLuiz commented Feb 22, 2022

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@JooLuiz
Copy link
Contributor Author

JooLuiz commented Feb 22, 2022

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)
  • Minor (backwards-compatible functionality)
  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant