Fix/orderby behaviour on custom query #562
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
gabrielHosino
requested review from
igorbrasileiro,
victorhmp and
Gmantiqueira
hiagolcm
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this solving?
When we use the SearchResultLayoutCustomQuery block, changing the orderby select does not change the order of the products shown. This PR seeks to correct that, by adding a check if the order key exists in the querystring of the URL.
How to test it?
You can use this Workspace with the new solution working. That link will take you to a new custom page the FPA BR team is working on. There, we use the SearchResultLayoutCustomQuery
Screenshots or example usage:
orderbyscreen.mp4
How does this PR make you feel? 🔗