Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: sponsored products first in list instead of last #642

Merged
merged 5 commits into from
Oct 24, 2023

Conversation

hcaula
Copy link
Contributor

@hcaula hcaula commented Oct 6, 2023

What problem is this solving?

The sponsored products were being concatenated to the organic search results instead of the inverse, causing them to be last in the list instead of first.

@hcaula hcaula self-assigned this Oct 6, 2023
@hcaula hcaula requested a review from a team as a code owner October 6, 2023 14:21
@hcaula hcaula requested review from hellofanny and removed request for a team October 6, 2023 14:21
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Oct 6, 2023

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Oct 6, 2023

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@hcaula hcaula merged commit fc7e73a into master Oct 24, 2023
4 of 6 checks passed
@hcaula hcaula deleted the fix/sponsored-products-order branch October 24, 2023 19:50
@hcaula hcaula restored the fix/sponsored-products-order branch October 24, 2023 19:50
@hcaula hcaula deleted the fix/sponsored-products-order branch October 24, 2023 19:50
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Oct 24, 2023

Your PR has been merged! App is being published. 🚀
Version 3.127.0 → 3.127.1

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.search-result@3.127.1

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants