Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sliderWidth #123

Merged
merged 2 commits into from Apr 2, 2019
Merged

Fix sliderWidth #123

merged 2 commits into from Apr 2, 2019

Conversation

GustavoMA
Copy link
Contributor

What is the purpose of this pull request?

This PR depends on vtex-apps/slider#16

What problem is this solving?

How should this be manually tested?

Here

Screenshots or example usage

Before
image
After
image

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@GustavoMA GustavoMA added the bug label Apr 2, 2019
@GustavoMA GustavoMA self-assigned this Apr 2, 2019
@GustavoMA GustavoMA mentioned this pull request Apr 2, 2019
Merged
4 tasks
@brunojdo brunojdo merged commit edba523 into master Apr 2, 2019
@brunojdo brunojdo deleted the fix/less-items branch April 2, 2019 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinch kevinch kevinch approved these changes

@brunojdo brunojdo brunojdo approved these changes

@JuanAlmeida12 JuanAlmeida12 JuanAlmeida12 approved these changes

Assignees

@GustavoMA GustavoMA

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GustavoMA @kevinch @brunojdo @JuanAlmeida12