Send productClick events to PixelManager #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasecdb
suggested changes
May 3, 2019
italo-batista
force-pushed
the
feature/send-prod-click-event
branch
from
ace9227
to
85a48b9
Compare
italo-batista
force-pushed
the
feature/send-prod-click-event
branch
from
7b22cda
to
191c5f0
Compare
lucasecdb
reviewed
May 8, 2019
italo-batista
force-pushed
the
feature/send-prod-click-event
branch
2 times, most recently
from
5c8f985
to
37c39f8
Compare
italo-batista
force-pushed
the
feature/send-prod-click-event
branch
3 times, most recently
from
fe0db1d
to
eae122d
Compare
jgfidelis
suggested changes
May 9, 2019
klzns
suggested changes
May 9, 2019
italo-batista
force-pushed
the
feature/send-prod-click-event
branch
from
248acc3
to
751f07d
Compare
salesfelipe
reviewed
May 10, 2019
| @@ -0,0 +1,9 @@ | |||
| import React from 'react' | |||
|
|
|||
| export function Pixel(Comp) { | |||
There was a problem hiding this comment.
Why did u add just the mock and not the test?
There was a problem hiding this comment.
I added the mock because some tests were breaking after my changes.
jgfidelis
approved these changes
May 13, 2019
klzns
approved these changes
May 14, 2019
brunojdo
force-pushed
the
feature/send-prod-click-event
branch
from
751f07d
to
f5fa04b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this solving?
Sending productClick event to Pixel Manager with the purpose of usage in google-analytics.
Types of changes
Workspace: https://aguaviva--storecomponents.myvtex.com/