Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SSR on graphql query #149

Closed
wants to merge 2 commits into from
Closed

Conversation

brunoabreu
Copy link
Contributor

What is the purpose of this pull request?

Enable SSR on graphql query

What problem is this solving?

It was disabled on v1.13.1 and was meant to be a temporary change.

How should this be manually tested?

Linking this branch will make shelves be rendered server-side.

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Jul 1, 2019

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch

  • Minor

  • Major

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@brunoabreu brunoabreu requested review from lbebber and klzns July 1, 2019 14:28
Copy link
Contributor

@lbebber lbebber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hold your horses: this requires a fix on the Slider component, due to an issue when the shelf has fewer than 4 items (actually, when it has fewer items than a full "page" and doesn't trigger the slider)

that issue needs to be fixed first

@brunoabreu
Copy link
Contributor Author

There is already a PR to do the same thing: #142

@brunoabreu brunoabreu closed this Jul 1, 2019
@brunoabreu brunoabreu deleted the feature/bring-ssr-back branch July 1, 2019 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants