Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/hover #170

Merged
merged 2 commits into from Aug 5, 2019
Merged

Feat/hover #170

merged 2 commits into from Aug 5, 2019

Conversation

jgfidelis
Copy link
Contributor

What is the purpose of this pull request?

FOr change image on hover feature

What problem is this solving?

Fetch imageLabel from graphql, also pass it to product-summary

How should this be manually tested?

https://fidimg--storecomponents.myvtex.com

Screenshots or example usage

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Aug 2, 2019

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch

  • Minor

  • Major

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@jgfidelis jgfidelis merged commit d44ec70 into master Aug 5, 2019
@jgfidelis jgfidelis deleted the feat/hover branch August 5, 2019 13:14
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Aug 5, 2019

Your PR has been merged! App is being published. 🚀
Version 1.23.1 → 1.24.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants