Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix itemsPerPage not being taken into consideration when greater than 5 #176

Merged
merged 3 commits into from
Aug 28, 2019

Conversation

victorhmp
Copy link
Contributor

What is the purpose of this pull request?

Give the user the option to set how many items should be displayed by Shelf on desktops.

What problem is this solving?

itemsPerPage prop would not be taken into consideration when greater than 5, as this limit was set by the ShelfContent component.

How should this be manually tested?

Workspace

Screenshots or example usage

Screen Shot 2019-08-27 at 8 09 04 PM

Types of changes

  • Bugfix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@victorhmp victorhmp added the bug label Aug 27, 2019
@victorhmp victorhmp self-assigned this Aug 27, 2019
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Aug 27, 2019

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch

  • Minor

  • Major

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@victorhmp victorhmp requested a review from a team August 27, 2019 23:12
@victorhmp victorhmp merged commit 2face43 into master Aug 28, 2019
@victorhmp victorhmp deleted the bug/shelf-max-items-per-page branch August 28, 2019 13:25
@victorhmp victorhmp restored the bug/shelf-max-items-per-page branch August 28, 2019 13:25
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Aug 28, 2019

Your PR has been merged! App is being published. 🚀
Version 1.28.0 → 1.28.1

@victorhmp victorhmp deleted the bug/shelf-max-items-per-page branch August 28, 2019 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants