Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue shelfs slider with seletor of sku with slider #99

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

wellingtonblack
Copy link

@wellingtonblack wellingtonblack commented Oct 4, 2022

What problem is this solving?

Problem with shelves with slider and sku selectors with sliders too

The shelf has a lot of skus, I need it to be in a slider format

How to test?

Open a shelf with a slider and in the pros of sku-selector put it as a slider

[Workspace](Link goes here!)
https://slider--cirilocabos.myvtex.com/

Screenshots or usage example:

before
image
later
image

Describe the alternatives you considered, if any.

Related to / Depends on

How does this PR make you feel? 馃敆

satisfied customer

![](put the .gif link here - it can be found under "advanced" on giphy)

@wellingtonblack wellingtonblack requested a review from a team as a code owner October 4, 2022 04:31
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Oct 4, 2022

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 馃

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 馃槥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants