Merge pull request #21 from vtex-apps/fix/disable-drag

Disable drag as default
vtex-apps · Apr 12, 2019 · 4206c17 · 4206c17
2 parents 1e2434e + 9ea141c
commit 4206c17
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,8 +7,16 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
+## [0.5.3] - 2019-04-12
+
+### Changed
+
+- Set draggable to false as default.
+
 ## [0.5.2] - 2019-04-10
+
 ### Fixed
+
 - Condition on `width` of `sliderFrame` when there is less items than the number of itens to show per page.
 
 ## [0.5.1] - 2019-04-02

diff --git a/manifest.json b/manifest.json
@@ -1,7 +1,7 @@
 {
   "name": "slider",
   "vendor": "vtex",
-  "version": "0.5.2",
+  "version": "0.5.3",
   "title": "VTEX Slider",
   "description": "A React Slider component that works well in SPA and SSR",
   "mustUpdateAt": "2020-01-30",

diff --git a/react/__tests__/__snapshots__/Slider.test.js.snap b/react/__tests__/__snapshots__/Slider.test.js.snap
@@ -13,7 +13,7 @@ exports[`<Slider /> component should match snapshot 1`] = `
   >
     <ul
       class="sliderFrame list pa0 h-100 ma0 flex"
-      style="width: 400%; transform: translate3d(0, 0, 0); transition: all 0ms ease-out; cursor: -webkit-grab;"
+      style="width: 400%; transform: translate3d(0, 0, 0); transition: all 0ms ease-out; cursor: default;"
     >
       <li
         class="inline-flex h-100 relative overflow-hidden"

diff --git a/react/__tests__/__snapshots__/SliderContainer.test.js.snap b/react/__tests__/__snapshots__/SliderContainer.test.js.snap
@@ -10,7 +10,7 @@ exports[`<SliderContainer /> component should match snapshot 1`] = `
     >
       <ul
         class="sliderFrame list pa0 h-100 ma0 flex"
-        style="width: 200%; transform: translate3d(0, 0, 0); transition: all 0ms ease-out; cursor: -webkit-grab;"
+        style="width: 200%; transform: translate3d(0, 0, 0); transition: all 0ms ease-out; cursor: default;"
       >
         <li
           class="inline-flex h-100 relative overflow-hidden"
@@ -48,7 +48,7 @@ exports[`<SliderContainer /> component should match snapshot with another tag 1`
     >
       <ul
         class="sliderFrame list pa0 h-100 ma0 flex"
-        style="width: 200%; transform: translate3d(0, 0, 0); transition: all 0ms ease-out; cursor: -webkit-grab;"
+        style="width: 200%; transform: translate3d(0, 0, 0); transition: all 0ms ease-out; cursor: default;"
       >
         <li
           class="inline-flex h-100 relative overflow-hidden"

diff --git a/react/components/Slider.js b/react/components/Slider.js
@@ -72,9 +72,9 @@ class Slider extends PureComponent {
       sliderFrame: '',
     },
     currentSlide: 0,
-    cursor: '-webkit-grab',
-    cursorOnMouseDown: '-webkit-grabbing',
-    draggable: true,
+    cursor: 'default',
+    cursorOnMouseDown: 'default',
+    draggable: false,
     duration: 250,
     easing: 'ease-out',
     loop: false,