Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for keyboard control #27

Merged
merged 3 commits into from
May 27, 2019
Merged

Add support for keyboard control #27

merged 3 commits into from
May 27, 2019

Conversation

matheusps
Copy link
Member

What is the purpose of this pull request?

As the title says.

What problem is this solving?

The user may want to control the slider using the keyboard arrows.

How should this be manually tested?

Linked @ workspace.
Try to use your left and right arrows to control the slider.

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@matheusps matheusps added the enhancement New feature or request label May 24, 2019
@matheusps matheusps self-assigned this May 24, 2019
Copy link

@rerissondaniel rerissondaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing update to CHANGELOG.md

@matheusps matheusps merged commit df3bf87 into next May 27, 2019
@matheusps matheusps deleted the feature/keyboard-mode branch May 27, 2019 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants