Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ssr flicker #30

Merged
merged 8 commits into from Jul 4, 2019
Merged

Fix/ssr flicker #30

merged 8 commits into from Jul 4, 2019

Conversation

lbebber
Copy link
Contributor

@lbebber lbebber commented Jul 4, 2019

What is the purpose of this pull request?

Prevents slider items flickering their widths (on certain screen sizes; tablet is still WIP), and visual glitches that are consequence of this, on the transition between SSR to CSR.

Test on https://lbebber--ecowaterqa.myvtex.com/

Before:
shelf-loading-bad-mobile

After:
shelf-loading-good-mobile

What problem is this solving?

How should this be manually tested?

Screenshots or example usage

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Jul 4, 2019

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch

  • Minor

  • Major

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@lbebber lbebber merged commit 8a50631 into master Jul 4, 2019
@lbebber lbebber deleted the fix/ssr-flicker branch July 4, 2019 18:49
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Jul 4, 2019

Your PR has been merged! App is being published. 🚀
Version 0.5.5 → 0.5.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants