Break Footer into smaller pieces using composition
#54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klzns
force-pushed
the
feature/composition
branch
from
7ab2751
to
6e907f6
Compare
klzns
force-pushed
the
feature/composition
branch
from
2def40d
to
62c3f9f
Compare
klzns
commented
Apr 10, 2019
| @@ -1,12 +1,12 @@ | |||
| import React, { Component } from 'react' | |||
There was a problem hiding this comment.
Just moved this file and fix lint
klzns
commented
Apr 10, 2019
| @@ -2,8 +2,8 @@ import PropTypes from 'prop-types' | |||
| import React from 'react' | |||
There was a problem hiding this comment.
Just moved this file and fixed lint
klzns
commented
Apr 10, 2019
| @@ -2,8 +2,8 @@ import React from 'react' | |||
| import PropTypes from 'prop-types' | |||
|
|
|||
| import footerList from './footerList' | |||
| import withImage from './withImage' | |||
There was a problem hiding this comment.
Just moved this file and fixed lint
klzns
commented
Apr 10, 2019
| @@ -3,8 +3,8 @@ import React, { Component, Fragment } from 'react' | |||
|
|
|||
| import Accordion from './Accordion' | |||
| import FooterLinkList, { FooterLinkItem } from './FooterLinkList' | |||
| import { objectLikeLinkArray } from './../propTypes' | |||
There was a problem hiding this comment.
Just moved this file and fixed lint
klzns
commented
Apr 10, 2019
| @@ -3,11 +3,11 @@ import React, { Component } from 'react' | |||
| import classNames from 'classnames' | |||
| import { Container } from 'vtex.store-components' | |||
|
|
|||
| import FooterBadgeList from './components/FooterBadgeList' | |||
There was a problem hiding this comment.
Just moved this file and fixed lint
klzns
commented
Apr 10, 2019
| @@ -1,11 +1,11 @@ | |||
| import PropTypes from 'prop-types' | |||
| import React, { Component } from 'react' | |||
| import { Collapse } from 'react-collapse' | |||
| import { injectIntl, intlShape, FormattedMessage } from 'react-intl' | |||
There was a problem hiding this comment.
Just moved this file and fixed lint
lbebber
suggested changes
Apr 10, 2019
| "accepted-payment-methods", | ||
| "logo", | ||
| "newsletter", | ||
| "unstable--menu", |
There was a problem hiding this comment.
Suggested change
| "unstable--menu", | |
| "menu", |
There was a problem hiding this comment.
I can't right now, since this is not published yet:
vtex-apps/menu#35
error: App build failed with message: I couldn't find an interface "menu". You need to declare it or depend on an app that declares it.
lbebber
reviewed
Apr 11, 2019
lbebber
approved these changes
Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Fix #46
Break Footer into reusable pieces to make it possible to build a more complex layout.
Components:
What problem is this solving?
Today Footer is a single component with a fixed layout. This makes it pretty strict in layout options.
How should this be manually tested?
Store:
https://breno--storecomponents.myvtexdev.com/
CMS:
https://breno--storecomponents.myvtexdev.com/admin/cms/storefront
Screenshots or example usage
Types of changes