Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined runtime variable from render-runtime at PoweredBy component #91

Closed
wants to merge 2 commits into from

Conversation

victorhmp
Copy link
Contributor

What is the purpose of this pull request?

Fix a runtime bug that prevented the PoweredBy component from rendering correctly.

How should this be manually tested?

https://footerfix--gc-ihm0094.myvtex.com/

Screenshots or example usage

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@victorhmp victorhmp added the bug Something isn't working label Oct 14, 2019
@victorhmp victorhmp self-assigned this Oct 14, 2019
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Oct 14, 2019

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch

  • Minor

  • Major

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Oct 14, 2019

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@victorhmp victorhmp requested review from gustavorosolem and a team October 14, 2019 18:43
@victorhmp victorhmp closed this Oct 14, 2019
@victorhmp victorhmp deleted the bugfix/undefined-runtime branch October 14, 2019 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants