Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default blocks implementation for the footer #95

Merged
merged 2 commits into from Dec 2, 2019

Conversation

victorhmp
Copy link
Contributor

@victorhmp victorhmp commented Dec 2, 2019

What is the purpose of this pull request?

Add a clean default blocks implementation for the footer block.

What problem is this solving?

There was no default implementation for the footer, so a store with no theme installed would look pretty weird.

How should this be manually tested?

https://defaultblocks--storecomponents.myvtex.com/

Screenshots or example usage

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Dec 2, 2019

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch

  • Minor

  • Major

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Dec 2, 2019

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@victorhmp victorhmp self-assigned this Dec 2, 2019
@victorhmp victorhmp marked this pull request as ready for review December 2, 2019 19:16
@victorhmp victorhmp merged commit 92bab04 into master Dec 2, 2019
@victorhmp victorhmp deleted the feature/new-default-implementation branch December 2, 2019 20:55
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Dec 2, 2019

Your PR has been merged! App is being published. 🚀
Version 2.17.2 → 2.18.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants