Please the linter gods #117
Conversation
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 Thank you so much for keeping our documentation up-to-date ❤️ |
kaisermann
force-pushed
the
refactor/lint
branch
from
cdc0b03
to
8714a83
Compare
| @@ -59,7 +59,7 @@ const useCumulativeHeightState = () => { | |||
| const getAccumulatedHeight = (index: number) => { | |||
| const sortedIndices = Object.keys(state) | |||
| .map(key => parseInt(key, 10)) | |||
| .sort() | |||
| .sort((a, b) => a - b) | |||
There was a problem hiding this comment.
Probably no one will have 9+ sticky rows, but if they do, this would sort it alphabetically 1, 10, 2, 3, 4....
|
Your PR has been merged! App is being published. 🚀 After the publishing process has been completed (check #vtex-io-notifications) and doing A/B tests with the new version, you can deploy your release by running:
After that your app will be updated on all accounts. For more information on the deployment process check the docs. 📖 |
What is the purpose of this pull request?
And fix a possible
.sort()bug.Types of changes