Feature/future header #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbebber
force-pushed
the
feature/future-header
branch
from
be9e4fe
to
25e6a54
Compare
lbebber
commented
Mar 28, 2019
lbebber
commented
Mar 28, 2019
| @@ -0,0 +1,140 @@ | |||
| import React, { Fragment, useEffect, useState } from 'react' | |||
There was a problem hiding this comment.
This file was mostly just moved from react to react/legacy, please refrain from delving too deeply into it for this PR
matheusps
reviewed
Mar 28, 2019
react/components/Row.js
Outdated
|
|
||
| return ( | ||
| <div | ||
| className={`w-100 top-0 ${sticky ? 'z-999' : '' } ${inverted ? 'bg-base--inverted c-on-base--inverted' : 'bg-base c-on-base'}`} |
There was a problem hiding this comment.
You could use classNames here
Co-Authored-By: lbebber <lucasbbebber@gmail.com>
matheusps
approved these changes
Mar 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
First, unstable implementation of the new composable header
Also adds stubs for some components which will be further developed in the future.
Also adds support for the
unstable--menublock on the now legacy header.What problem is this solving?
How should this be manually tested?
Screenshots or example usage
Types of changes