Add LocaleSwitcher #89
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Creating LocaleSwitcher Add CHANGELOG
thalytafabrine
force-pushed
the
feature/locale-switcher
branch
from
2078b9f
to
116f6c2
Compare
4 tasks
thayannevls
reviewed
May 23, 2019
| @@ -6,6 +6,7 @@ | |||
| "admin/editor.header.link.url": "admin/editor.header.link.url", | |||
| "admin/editor.header.show.searchbar.title": "admin/editor.header.show.searchbar.title", | |||
| "admin/editor.header.show.login.title": "admin/editor.header.show.login.title", | |||
| "admin/editor.header.show.localeswitcher.title": "admin/editor.header.show.localeswitcher.title", | |||
There was a problem hiding this comment.
Should this appear on /admin? It's not working for me
CHANGELOG.md
Outdated
| @@ -6,6 +6,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) | |||
| and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html). | |||
|
|
|||
| ## [Unreleased] | |||
| ### Added | |||
| - Adds support for `localeSwitcher`. | |||
There was a problem hiding this comment.
Suggested change
| - Adds support for `localeSwitcher`. | |
| - Support for `localeSwitcher`. |
GustavoMA
reviewed
May 23, 2019
| @@ -134,6 +138,12 @@ Header.schema = { | |||
| default: true, | |||
| isLayout: true, | |||
| }, | |||
| showLocaleSwitcher: { | |||
There was a problem hiding this comment.
I wasn't able to see this configuration in the storefront, can you take a look into that?
klzns
suggested changes
May 23, 2019
messages/es.json
Outdated
| @@ -5,6 +5,7 @@ | |||
| "admin/editor.header.logo.image": "Imagen del logotipo", | |||
| "admin/editor.header.link.url": "Link del logotipo", | |||
| "admin/editor.header.show.searchbar.title": "Mostrar Busca", | |||
| "admin/editor.header.show.localeswitcher.title": "Mostrar alternador de localidade", | |||
There was a problem hiding this comment.
Suggested change
| "admin/editor.header.show.localeswitcher.title": "Mostrar alternador de localidade", | |
| "admin/editor.header.show.localeswitcher.title": "Mostrar selector de idioma", |
messages/pt.json
Outdated
| @@ -6,6 +6,7 @@ | |||
| "admin/editor.header.link.url": "Link da Logo", | |||
| "admin/editor.header.show.searchbar.title": "Mostrar Busca", | |||
| "admin/editor.header.show.login.title": "Mostrar Login", | |||
| "admin/editor.header.show.localeswitcher.title": "Mostrar alternador de localidade", | |||
There was a problem hiding this comment.
Suggested change
| "admin/editor.header.show.localeswitcher.title": "Mostrar alternador de localidade", | |
| "admin/editor.header.show.localeswitcher.title": "Mostrar seletor de idioma", |
| @@ -47,6 +48,7 @@ | |||
| "minicart", | |||
| "login", | |||
| "search-bar", | |||
| "locale-switcher", | |||
There was a problem hiding this comment.
You should create an independent block for locale-switcher as well.
So it will work with the header-layout
4 tasks
Creating LocaleSwitcher Add CHANGELOG
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Creation of the component
LocaleSwitcherthat allows the user to select the language of the storeThis PR depends of these ones:
vtex-apps/store-components#453
vtex-apps/store-theme#140
How should this be manually tested?
Access this workspace
Screenshots or example usage
Types of changes