Feature/centering #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klzns
approved these changes
Jun 4, 2019
| const ForceCenter = ({ children }) => ( | ||
| <div | ||
| className="absolute left-0 right-0 flex justify-center z-1" | ||
| style={{ pointerEvents: 'none' }} |
There was a problem hiding this comment.
Why is that? Just out of curiosity
There was a problem hiding this comment.
because it creates a transparent div with 100% of the width, which might cover elements behind it and render the user unable to click through
react/ForceCenter.js
Outdated
|
|
||
| const ForceCenter = ({ children }) => ( | ||
| <div | ||
| className="absolute left-0 right-0 flex justify-center z-1" |
There was a problem hiding this comment.
Shouldn't we add a css handle?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Adds functionality to force centering elements on header, by way of the new
header-force-centerblock.View here: (used on the logo, which is centered regardless of the content by its side) https://lbebber4--storecomponents.myvtex.com/
What problem is this solving?
How should this be manually tested?
Screenshots or example usage
Types of changes