Fix/image title attr #24
Conversation
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
| "admin/editor.image-list.images.link.noFollow.title": "Should be a nofollow link", | ||
| "admin/editor.image-list.images.link.title.title": "Title for the link", |
There was a problem hiding this comment.
This is not being used, is it?
There was a problem hiding this comment.
I think not but I don't have 100% sure. Do you think we can remove that(All link messages)?
There was a problem hiding this comment.
If there's no reference to this string in this project, yes
| "admin/editor.image-list.images.link.noFollow.title": "Should be a nofollow link", | ||
| "admin/editor.image-list.images.link.title.title": "Title for the link", |
There was a problem hiding this comment.
If there's no reference to this string in this project, yes
|
Your PR has been merged! App is being published. 🚀 After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:
After that your app will be updated on all accounts. For more information on the deployment process check the docs. 📖 |
What problem is this solving?
It was lefting some steps to finish adding the title attribute to Image/ImageList/ImageSlider components in the image/link anchors
How to test it?
You can go to CMS -> SiteEditor -> ImageList and change the title attribute of the images/links. Now, in the worskpace, you will have to inspect image/link tag in the ImageList section(the last) to check if the attribute was updated!
https://vitorflg--storecomponents.myvtex.com/admin/cms/site-editor
https://vitorflg--storecomponents.myvtex.com/
How does this PR make you feel? 🔗