Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/lazy #59

Merged
merged 6 commits into from Feb 10, 2020
Merged

Feature/lazy #59

merged 6 commits into from Feb 10, 2020

Conversation

lbebber
Copy link
Contributor

@lbebber lbebber commented Jan 10, 2020

What is the purpose of this pull request?

Loads content lazily

https://lazytelemarketing--storecomponents.myvtex.com/

What problem is this solving?

How should this be manually tested?

Screenshots or example usage

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@lbebber lbebber requested a review from a team January 10, 2020 14:58
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Jan 10, 2020

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch

  • Minor

  • Major

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Jan 10, 2020

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@@ -0,0 +1,94 @@
import { compose, path } from 'ramda'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is just moving code from the root of the react dir to the components dir

@lbebber lbebber merged commit c45dda4 into master Feb 10, 2020
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Feb 10, 2020

Your PR has been merged! App is being published. 🚀
Version 2.9.8 → 2.10.0

After the publishing process has been completed (check #vtex-io-notifications) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.telemarketing@2.10.0

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

@lbebber lbebber deleted the feature/lazy2 branch February 10, 2020 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants