Adding partytown + gtm #167
Conversation
|
✔️ Deploy Preview for basestore ready! 🔨 Explore the source changes: a55fbe8 🔍 Inspect the deploy log: https://app.netlify.com/sites/basestore/deploys/61dc45723199db000792603b 😎 Browse the preview: https://deploy-preview-167--basestore.netlify.app/bundle-stats |
Gatsby Cloud Build Reportbasestore 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 2m PerformanceLighthouse report
|
Gatsby Cloud Build Reportbasestore 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 1m PerformanceLighthouse report
|
Preview is readyThis pull request generated a Preview👀 Preview: https://preview-167--base.preview.vtex.app |
igorbrasileiro
requested review from
lariciamota,
Gmantiqueira,
a team and
victorhmp
There was a problem hiding this comment.
I've left some comments. Besides them, I also think it'd be super interesting for us to have a doc (it can be small) explaining how we're using partytown - maybe going through things you wish you knew when you started this - and the pros and cons of using it, like having no way to debug the events via GTM.
igorbrasileiro
force-pushed
the
feat/partytown-gtm
branch
from
75e9b0c
to
4097aa1
Compare
igorbrasileiro
force-pushed
the
feat/partytown-gtm
branch
from
2819b02
to
b2ce43a
Compare
gatsby-ssr.js
Outdated
| ]) | ||
| } else if (process.env.NODE_ENV === 'development') { | ||
| // eslint-disable-next-line | ||
| console.log( |
There was a problem hiding this comment.
| console.log( | |
| console.warning( |
gatsby-ssr.js
Outdated
| console.warn( | ||
| 'gtmContainerId is not set. Google Tag Manager will not work until you provide a valid container id.' |
There was a problem hiding this comment.
This is already great! But how about also adding a link to https://developers.google.com/tag-platform/tag-manager/web#standard_web_page_installation, to make it easier for someone who doesn't know what the container ID is?
There was a problem hiding this comment.
Or even better! Since this is in the store's code, and users will get this from a starter, how about adding something like "Check the analytics section on your store.config.js file."
Co-authored-by: Ícaro Azevedo <icazevedo10@gmail.com>
igorbrasileiro
force-pushed
the
feat/partytown-gtm
branch
from
18fde08
to
2cc2579
Compare
Co-authored-by: Ícaro Azevedo <icazevedo10@gmail.com>
Co-authored-by: Ícaro Azevedo <icazevedo10@gmail.com>
What's the purpose of this pull request?
This PR adds the https://github.com/builderio/partytown and google tag manager.
Pros:
How it works?
Tell us the role of the new feature, or component, in its context.
How to test it?
Describe the steps with bullet points. Is there any external reference, link, or example?
References
Spread the knowledge: is this any content you used to create this PR that is worth sharing?
Extra tip: add references to related issues or mention people important to this PR may be good for the documentation and reviewing process