Skip to content
This repository has been archived by the owner on Jun 2, 2022. It is now read-only.

chore: Remove frontend computing #411

Merged
merged 1 commit into from Mar 23, 2022
Merged

chore: Remove frontend computing #411

merged 1 commit into from Mar 23, 2022

Conversation

tlgimenes
Copy link
Contributor

@tlgimenes tlgimenes commented Mar 22, 2022 •
edited

What's the purpose of this pull request?

This PR moves frontend computing to the backend. Also, this PR removes a duplication in computing in the discount hook

How does it work?

Fore more info: vtex/faststore#1184

Checklist

  • CHANGELOG entry added

@tlgimenes tlgimenes mentioned this pull request Mar 22, 2022
Merged
@tlgimenes tlgimenes added the performance Improvements to performance label Mar 22, 2022
@netlify
Copy link

netlify bot commented Mar 22, 2022 •
edited

✅ Deploy Preview for basestore ready!

Name Link
🔨 Latest commit 72ea1ab
🔍 Latest deploy log https://app.netlify.com/sites/basestore/deploys/623b2d5ebfa4ec0009cadc00
😎 Deploy Preview https://deploy-preview-411--basestore.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@gatsby-cloud
Copy link

gatsby-cloud bot commented Mar 22, 2022 •
edited

Gatsby Cloud Build Report

basestore

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 10m

Performance

Lighthouse report

Metric Score
Performance 🔶 89
Accessibility 💚 100
Best Practices 💚 100
SEO 💚 93

🔗 View full report

@vtex-sites
Copy link

vtex-sites bot commented Mar 22, 2022 •
edited

Preview is ready

This pull request generated a Preview

👀   Preview: https://preview-411--base.preview.vtex.app
🔬   Go deeper by inspecting the Build Logs
📝   based on commit 6a341cc

@tlgimenes tlgimenes marked this pull request as ready for review March 22, 2022 18:43
@tlgimenes tlgimenes requested a review from a team March 22, 2022 20:04
@igorbrasileiro
Copy link
Contributor

Test running 15 tests on PSI API
Page result - https://base.vtex.app/office

Metric Mean Standard deviation
cumulative_layout_shift 0.0 0.0
first_contentful_paint 1692.7594413206884 59080.304253151284
first_contentful_paint_3g 3432.9380624641144 131556.48480177493
js_execution_time 2525.4320000000007 76675.82521600056
largest_contentful_paint 1934.1760007765622 45317.714524977455
speed_index 2156.6746568765616 541.6298155747413
time_to_interactive 4129.176709985026 123241.37480460895
total_blocking_time 955.6348128033937 26710.60323919151

Page result - https://sfj-639d713--base.preview.vtex.app/office

Metric Mean Standard deviation
cumulative_layout_shift 0.0 0.0
first_contentful_paint 1107.1993949923096 5274.491238530088
first_contentful_paint_3g 2307.4970969128412 81326.91439724757
js_execution_time 1898.886666666667 797.8680888888244
largest_contentful_paint 1995.4497902240255 3396.2220568915504
speed_index 1704.820057034546 65622.02057395902
time_to_interactive 3648.8842847357637 1756.9618015963995
total_blocking_time 782.8793058643357 14037.946095814648

lariciamota
lariciamota approved these changes Mar 23, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@tlgimenes tlgimenes merged commit 6a341cc into master Mar 23, 2022
@tlgimenes tlgimenes deleted the chore/backend branch March 23, 2022 14:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@igorbrasileiro igorbrasileiro igorbrasileiro approved these changes

@lariciamota lariciamota lariciamota approved these changes

Assignees
No one assigned
Labels
performance Improvements to performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tlgimenes @igorbrasileiro @lariciamota