chore: inlining additionalProperty serialization for cart item id

vtex-sites · May 25, 2022 · 41eb7a6 · 41eb7a6
1 parent 9366100
commit 41eb7a6
Showing 1 changed file with 3 additions and 14 deletions.
diff --git a/src/sdk/cart/validate.ts b/src/sdk/cart/validate.ts
@@ -70,27 +70,16 @@ export const ValidateCartMutation = gql`
 
 export const isGift = (item: CartItem) => item.price === 0
 
-const serializeAdditionalProperty = (itemOffered: CartItem['itemOffered']) => {
-  if (
-    !itemOffered.additionalProperty ||
-    itemOffered.additionalProperty?.length === 0
-  ) {
-    return null
-  }
-
-  return itemOffered.additionalProperty
-    .map(({ propertyID }) => propertyID)
-    .join('-')
-}
-
 export const getItemId = (
   item: Pick<CartItem, 'itemOffered' | 'seller' | 'price'>
 ) =>
   [
     item.itemOffered.sku,
     item.seller.identifier,
     item.price,
-    serializeAdditionalProperty(item.itemOffered),
+    item.itemOffered.additionalProperty
+      ?.map(({ propertyID }) => propertyID)
+      .join('-'),
   ]
     .filter(Boolean)
     .join('::')