Feat: integrate with client-cms #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: Arthur Andrade <arthurfelandrade@gmail.com>
ArthurTriis1
force-pushed
the
feat/FSSS-352-integrate-with-client-cms
branch
from
91bce9b
to
8016c91
Compare
Signed-off-by: Arthur Andrade <arthurfelandrade@gmail.com>
Preview is readyThis pull request generated a Preview👀 Preview: https://preview-172--gatsby.preview.vtex.app |
Lighthouse ReportsHere are the Lighthouse reports of this Pull Request📝 Based on commit 8532c62
|
Signed-off-by: Arthur Andrade <arthurfelandrade@gmail.com>
ArthurTriis1
force-pushed
the
feat/FSSS-352-integrate-with-client-cms
branch
from
4e12bac
to
24c28cb
Compare
Signed-off-by: Arthur Andrade <arthurfelandrade@gmail.com>
Signed-off-by: Arthur Andrade <arthurfelandrade@gmail.com>
Signed-off-by: Arthur Andrade <arthurfelandrade@gmail.com>
Signed-off-by: Arthur Andrade <arthurfelandrade@gmail.com>
Signed-off-by: Arthur Andrade <arthurfelandrade@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Arthur Andrade arthurfelandrade@gmail.com## What's the purpose of this pull request?
*this PR is a refactoring of feat: integrate with VTEX headless CMS #104 by @danzanzini using the client-cms.
How does it work?
This PR integrates the Faststore Starter with VTEX headless CMS using the Client CMS Package.
The integration was done in index page, where with the gatsby getServerData function all data was fetched, and the page was mounted.
Was added a src/cms/cmsHomeFallback.ts file as fallback for cases of fail in a request or for a project that don't use CMS integration.
The integration with GlobalCMS items like the Alert should be done in other task.
How to test it?
Open the preview link, visit the index page (/) and see if it's everything fine.
References
Client CMS Package
getServerData function
Checklist
You may erase this after checking them all ;)
PR Title and Commit Messages
PR Description
Breaking change,Enhancement,BugorChore.ComponentNamecomponent.useWindowDimensionshook.Documentation