Feature/country field disabling when editing Address Form

[efremov-av]

What is the purpose of this pull request?

For profile V2 addresses schema we can´t change the country of an existing address because the schema is different per country so we are disabling this option when editing an address to be compliant with this structure.

How should this be manually tested?

Account to test: dunnesstoresqa
Workspace: devalex

https://devalex--dunnesstoresqa.myvtex.com/account

Open Address Edit form in My Account Addresses

Screenshots or example usage

Before:

Uploading Screen Recording 2024-07-04 at 12.30.43.mov…

After:

Screen.Recording.2024-07-04.at.12.26.51.mov

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Requires change to documentation, which has been updated accordingly.

[vtex-io-ci-cd]

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

• Patch (backwards-compatible bug fixes)

• Minor (backwards-compatible functionality)

• Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

• No thanks, I would rather do it manually 😞

[lpolon]

I believe this is not a good way to archive the desired behaviour.

As far as I can tell, even though it is a old project, I can't find any other example in the project where there is a mutation of props.

As far as I can tell, This change is a big no-no, because React assumes that props are readonly:
https://react.dev/reference/rules/components-and-hooks-must-be-pure#props
https://stackoverflow.com/questions/51435476/why-props-in-react-are-read-only

Please let me know whatever I am missing in my understanding.

Reading the project, my understanding is that all address form state should be derived from the address itself while it does not own the state.

My suggestion is to just pass this value where you need. Specifically:
https://github.com/vtex-apps/my-account/blob/8567571485d205a97e38ff1e6ec914096df4d171/react/components/pages/AddressEdit.tsx#L70

[lpolon]

If you are willing to merge this PR, I suggest investigating why the build step on the CI is still peding. I just clicked "rebuild" from details. Let's see.

edit: build is done

[beatrizmaselli]

Closing this PR for this:
vtex-apps/my-account#303