Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature / VBase and graphQL operations added #66

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

GabrielBarross
Copy link
Contributor

What is the purpose of this pull request?

Adding a VBase operation to be activated when a value is not found by the catalog API, it must run on the commissions Middleware.
For the front end to access the VBase information, there were 2 resolvers created as well.

What problem is this solving?

SKUs error message

How to test it?

Accessing the link below and uploading some spreadsheets
https://commissionstest--bibiafiliados.myvtex.com/admin/affiliates-commissions

How does this PR make you feel? 馃敆

Types of changes

  • Chore (non-breaking change which doesn't change any functionalities)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@GabrielBarross GabrielBarross requested a review from a team as a code owner November 8, 2022 21:04
@GabrielBarross GabrielBarross requested review from MIzidio and anamaiabap and removed request for a team November 8, 2022 21:04
@GabrielBarross GabrielBarross self-assigned this Nov 8, 2022
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Nov 8, 2022

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 馃

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 馃槥

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

Fails
馃毇

We follow keepachangelog standards.

Please, change the file CHANGELOG.md adding a small summary of your changes under the [Unreleased] section. Example:

 ## [Unreleased]

+ ### Fixed
+ - Issue with image sizing in the SKU Selector.

Possible types of changes:

  • Added for new features.
  • Changed for changes in existing functionality.
  • Deprecated for soon-to-be removed features.
  • Removed for now removed features.
  • Fixed for any bug fixes.
  • Security in case of vulnerabilities.

Generated by 馃毇 dangerJS against 335afb9

Copy link

@wagnerlduarte wagnerlduarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Lint are configured correctly in your local project? Because is it giving some alerts about indentation and rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants