Fix SKU selector #2254
Merged
Fix SKU selector #2254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
gvc
requested review from
hellofanny and
lariciamota
and removed request for
a team
eduardoformiga
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
When implementing the Variant Swatch Image I noticed that if a SKU Selector had only one option the image would not appear. Upon inspecting this hook I noticed that if there's ony one image the code would infer they were all the same and only show the label, but there's the special case of only one image. This PR fixes this.
How to test it?
Go to the preview and see the awesome-chair product and switch to the Plastic or Iron material SKUs. You should see an image on the Size selector. On the starter store awesome-chair will not show the image.