[TCM-328] Prevent generated files for hCMS from being empty #2275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
victorhmp
changed the title
victorhmp
requested review from
emersonlaurentino and
renatamottam
and removed request for
a team
victorhmp
force-pushed
the
fix/empty-cms-files
branch
from
e9ec9bf
to
50bda41
Compare
eduardoformiga
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
Fixing a bug on how files for hCMS are being generated. If a store did not define their own
content-types.jsonorsections.jsonfiles, the default content from@faststore/corewould be ignored whenfaststore cms-syncis executed.How to test it?
@faststore/cliversion from the Deploy Preview below.faststore cms-sync --dry-run(to not actuality sync the files), without creating a/cmsfolder or creating one that's laking eithercontent-types.jsonorsections.json.References
Motivated by: https://vtex.slack.com/archives/C0164SHMAV9/p1710332274381219.