Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Major] Feat: Add New Icons #2288

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

[Major] Feat: Add New Icons #2288

wants to merge 7 commits into from

Conversation

renatamottam
Copy link
Contributor

@renatamottam renatamottam commented Apr 22, 2024

What's the purpose of this pull request?

This PR updates our icon library to fit the new VTEX Design Foundation.

Activities

For the Future

  • Improve flow of adding new icons
  • Add Icons page back to documentation

How it works?

Before After
Screenshot 2024-04-23 at 11 36 05 Screenshot 2024-04-23 at 14 07 09

For now, we're going to accept both symbol styles, but all new symbols added by us will be following the new pattern and the old will be deprecated eventually. Some important changes on the Icon component:

  • Icon's size will be defined using size prop
  • Our new default size is 24
  • height, width and weight props are now marked as deprecated (but it's still working)

How to test it?

Our old doc is updated for testing and reviewing purposes: https://faststore-site-git-feat-new-icons-faststore.vercel.app/docs/icons

@renatamottam renatamottam self-assigned this Apr 22, 2024
Copy link

vercel bot commented Apr 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
faststore-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2024 7:51pm

Copy link

codesandbox-ci bot commented Apr 22, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Should be used as reference
@renatamottam renatamottam changed the title Feat: Add New Icons [Major] Feat: Add New Icons May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant