fix: added missing prop to fix pdp NextSeo component #2291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivaltech
requested review from
emersonlaurentino and
lucasfp13
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
lucasfp13
requested changes
Apr 24, 2024
emersonlaurentino
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
Fix the PDP seo title. The NextSeo component of the product page does not have the titleTemplate property, which is responsible for adding the titleTemplate to the title when navigating to the PDP directly.
Try to reproduce this issue by copy+paste the product url in the browser instead of navigating to the pdp.
native.issue.mp4
For example, the SearchPage component does have this property and works correctly:
How it works?
Adding the same property to the PDP component resolves the issue: