Feat: POC Next 13 global sections #2299
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
eduardoformiga
commented
May 2, 2024
| @@ -0,0 +1,174 @@ | |||
| 'use client' | |||
eduardoformiga
commented
May 2, 2024
| @@ -0,0 +1,36 @@ | |||
| 'use client' | |||
eduardoformiga
commented
May 2, 2024
| @@ -0,0 +1,56 @@ | |||
| 'use client' | |||
eduardoformiga
commented
May 2, 2024
| @@ -0,0 +1,42 @@ | |||
| 'use client' | |||
eduardoformiga
commented
May 2, 2024
| @@ -0,0 +1,120 @@ | |||
| 'use client' | |||
eduardoformiga
commented
May 2, 2024
| @@ -0,0 +1,144 @@ | |||
| 'use client' | |||
eduardoformiga
commented
May 2, 2024
| @@ -0,0 +1,17 @@ | |||
| 'use client' | |||
eduardoformiga
commented
May 2, 2024
| @@ -0,0 +1,95 @@ | |||
| 'use client' | |||
eduardoformiga
commented
May 2, 2024
| @@ -0,0 +1,16 @@ | |||
| 'use client' | |||
eduardoformiga
commented
May 2, 2024
| @@ -0,0 +1,16 @@ | |||
| 'use client' | |||
eduardoformiga
commented
May 2, 2024
| @@ -0,0 +1,29 @@ | |||
| 'use client' | |||
eduardoformiga
commented
May 2, 2024
| @@ -0,0 +1,116 @@ | |||
| 'use client' | |||
There was a problem hiding this comment.
Client Component - Temporary page code
eduardoformiga
commented
May 2, 2024
| @@ -0,0 +1,36 @@ | |||
| 'use client' | |||
eduardoformiga
commented
May 2, 2024
| @@ -0,0 +1,67 @@ | |||
| 'use client' | |||
eduardoformiga
commented
May 2, 2024
| @@ -0,0 +1,11 @@ | |||
| 'use client' | |||
eduardoformiga
commented
May 2, 2024
| @@ -1,5 +1,6 @@ | |||
| /// <reference types="next" /> | |||
| /// <reference types="next/image-types/global" /> | |||
| /// <reference types="next/navigation-types/compat/navigation" /> | |||
There was a problem hiding this comment.
next automatically generate this
eduardoformiga
commented
May 2, 2024
Comment on lines
+44
to
+52
| // Make css order works as expected in Next 13. See https://github.com/vercel/next.js/issues/51030#issuecomment-2005254907 | ||
| config.plugins.push( | ||
| new webpack.BannerPlugin({ | ||
| banner: '@layer base, components, theme;', | ||
| test: /\.css$/, | ||
| raw: true, | ||
| entryOnly: false, | ||
| }) | ||
| ) |
There was a problem hiding this comment.
Fix styles order issue. see the comment
eduardoformiga
commented
May 2, 2024
| "name": "next" | ||
| } | ||
| ], | ||
| "strictNullChecks": false |
There was a problem hiding this comment.
needed to make Section Override work as previously.
eduardoformiga
commented
May 2, 2024
| SearchInput as UISearchInput, | ||
| SearchInputField as UISearchInputField, | ||
| } from '@faststore/ui' | ||
| import { useRouter } from 'next/navigation' |
There was a problem hiding this comment.
'next/navigation' from next 13 instead of 'next/router'
eduardoformiga
commented
May 2, 2024
Comment on lines
+41
to
+45
| /* TODO: we should use DraftMode instead of preview mode in Next 13 */ | ||
| } | ||
| const { sections } = await getPage<PageContentType>({ | ||
| contentType: GLOBAL_SECTIONS_CONTENT_TYPE, | ||
| }) |
There was a problem hiding this comment.
There is a task in our backlog to use draft mode instead of previewData (hCMS).
eduardoformiga
commented
May 2, 2024
Comment on lines
+58
to
+59
| {/* TODO: we should use metadata api from Next 13 */} | ||
| {/* <DefaultSeo norobots={storeConfig.experimental.noRobots} /> */} |
There was a problem hiding this comment.
DefaultSeo doesn't work as expected in Next 13. We also have a task to use the native SEO (Metadata) API, instead.
eduardoformiga
commented
May 2, 2024
Comment on lines
+123
to
+156
| // BannerText: { | ||
| // Section: typeof BannerText | ||
| // components: { | ||
| // BannerText: ComponentOverrideDefinition<BannerTextProps, BannerTextProps> | ||
| // BannerTextContent: ComponentOverrideDefinition< | ||
| // BannerTextContentProps, | ||
| // BannerTextContentProps | ||
| // > | ||
| // } | ||
| // } | ||
| // Breadcrumb: { | ||
| // Section: typeof Breadcrumb | ||
| // components: { | ||
| // Breadcrumb: ComponentOverrideDefinition<BreadcrumbProps, BreadcrumbProps> | ||
| // Icon: ComponentOverrideDefinition<IconProps, IconProps> | ||
| // } | ||
| // } | ||
| // EmptyState: { | ||
| // Section: typeof EmptyState | ||
| // components: { | ||
| // EmptyState: ComponentOverrideDefinition< | ||
| // PropsWithChildren<EmptyStateProps>, | ||
| // EmptyStateProps | ||
| // > | ||
| // } | ||
| // } | ||
| // Hero: { | ||
| // Section: typeof Hero | ||
| // components: { | ||
| // Hero: ComponentOverrideDefinition<HeroProps, HeroProps> | ||
| // HeroImage: ComponentOverrideDefinition<HeroImageProps, HeroImageProps> | ||
| // HeroHeader: ComponentOverrideDefinition<HeroHeaderProps, HeroHeaderProps> | ||
| // } | ||
| // } |
There was a problem hiding this comment.
We should uncomment these lines as we migrate these sections into the pages.
eduardoformiga
commented
May 2, 2024
Comment on lines
+65
to
+66
| /** This type wizardry is here because the props won't behave correctly if nothing is done */ | ||
| // @ts-ignore |
There was a problem hiding this comment.
ts-ignore was needed to make the SectionOverride works as previously.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR was used to make experiments (POC) while migrating the global section to Next 13.
Along the way, we created and adjusted some tasks and added comments to guide the migration.
This PR is gigantic because most components were moved from the src folder to the app folder to make it Server Components, with a few updates to make them use the updated path.
As the Next complains about client components, we added the 'use client' to some components.
Also, other adjusts were made needed, as you can see in this PR
I suggest you see the comments below, which are linked to the files.