Feat: Next 13 Root Layout #2300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
eduardoformiga
requested review from
renatamottam and
lariciamota
and removed request for
a team
lariciamota
reviewed
May 6, 2024
We can put as this doc explains. |
lariciamota
approved these changes
May 7, 2024
eduardoformiga
added a commit
that referenced
this pull request
May 7, 2024
Depends on - #2298 - #2300 ## What's the purpose of this pull request? This PR aims to migrate to the new way to fetch data using Next 13. ## How it works? instead of `getServerStaticProps`, now we fetch the data directly from the root `layout.tsx`. ## How to test it? locally, add a console log after the fetch function. ## References https://nextjs.org/docs/app/building-your-application/data-fetching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on
What's the purpose of this pull request?
This PR aims to create the root
layout.tsxand bring the components from thesrcfolder to theappfolder.Most of the changes from this PR are related to the path change to the
appfolder. But there are also new 'use clients' added to some components.The sections should be implemented/moved in other PR's related to another JIRA task.
How to test it?
Make sure that the older pages are working as expected and also the
http://localhost:3000/fs-next-updateis rendering (blank) without errors.Starter PR
TBD
References
https://nextjs.org/docs/app/api-reference/file-conventions/layout