Bubbling up the same error that redigo uses so that the logic to shor… #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t circuit cache is consistent when using cluster mode
fabianaferreira
approved these changes
May 19, 2023
eduardocesb
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t circuit cache is consistent when using cluster mode
What is the purpose of this pull request?
I believe this may be the source of our 404 troubles since we aren't short circuiting the same way as we were before when using redigo. With this change it will bubble up the same error that we were getting and cause it to follow the same logic.
What problem is this solving?
I have a suspicion that since this isn't short circuiting and returning false that we are indicating to the caller that there was no error and that the content was nil.
How should this be manually tested?
Not really sure tbh
Types of changes