New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update runnable schema in runtime when provider app changes version #420
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in my own workspace without the code linked which triggered the error.
Linked all the code in my workspace, and rerun the query and it worked fine 👍
Steps:
vtex link
with https://github.com/vtex/graphql-server/pull/251- Open a terminal with this code and run
yarn
,yarn build
andyarn link
- Open a terminal with search-resolver@1.x and run
yarn link @vtex/api
inside thenode
folder, and thenvtex link
- Open a terminal with search-graphql add a new field in the Product type and query it in the GraphQL IDE just like the example bellow:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM would wait for @tlgimenes review
94acae9
to
15d4a0b
Compare
What is the purpose of this pull request?
Update graphql runnable schema in runtime when a new version of a provider app is installed in the same workspace.
What problem is this solving?
It stops breaking the store when a new field is added and called by a store.
How should this be manually tested?
You can use this workspace that already has a modified graphql schema, and link a new version of search-graphql and add new fields.
This contribution depends on this one, which is deployed.
Screenshots or example usage
To test in other workspace:
Types of changes