Skip to content

Commit

Permalink
Fix #30 partial config updates
Browse files Browse the repository at this point in the history
  • Loading branch information
Sherex committed Nov 17, 2020
1 parent e19f212 commit 10aaf16
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 2 deletions.
3 changes: 1 addition & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
"author": "Ingar Helgesen (https://github.com/sherex)",
"license": "MIT",
"dependencies": {
"deepmerge": "^4.2.2",
"pkg-dir": "^4.2.0",
"syslog-client": "^1.1.1"
},
Expand Down
2 changes: 2 additions & 0 deletions src/index.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
const syslog = require('syslog-client')
const deepmerge = require('deepmerge')
const logLevelMapper = require('./lib/log-level-mapper')
const formatDateTime = require('./lib/format-date-time')
const { pkg } = require('./lib/get-package-json')
Expand All @@ -14,6 +15,7 @@ const loggerOptions = {
// Dependencies for the imported factory functions
const logConfigDeps = {
syslog,
deepmerge,
loggerOptions,
envVariables: process.env
}
Expand Down
3 changes: 3 additions & 0 deletions src/lib/log-config-factory.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
function _logConfigFactory (options = {},
{
syslog,
deepmerge,
loggerOptions,
envVariables
}) {
options = deepmerge(loggerOptions.previousOptions, options)
loggerOptions.previousOptions = options
if (
(!options || !options.remote) &&
envVariables.PAPERTRAIL_HOST &&
Expand Down
2 changes: 2 additions & 0 deletions src/lib/log-config-factory.test.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
const deepmerge = require('deepmerge')
const logConfigFactory = require('./log-config-factory')

function createLogConfig (fakeDeps, options) {
Expand All @@ -8,6 +9,7 @@ function createLogConfig (fakeDeps, options) {
Udp: 'udp'
}
},
deepmerge,
loggerOptions: {},
envVariables: {},
...fakeDeps
Expand Down

0 comments on commit 10aaf16

Please sign in to comment.