Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative included file paths not resolved properly #61

Closed
papergirl opened this issue Sep 9, 2015 · 3 comments
Closed

Relative included file paths not resolved properly #61

papergirl opened this issue Sep 9, 2015 · 3 comments

Comments

@papergirl
Copy link

Files which are included defines i.e. the following define(["./kendo.core.min"]) are not resolved correctly they get resolved to :\kendo.core.min.js instead of the correct relative path of
:\kendo\kendo.core.min.js

papergirl pushed a commit to papergirl/RequireJSDotNet that referenced this issue Sep 9, 2015
@Spudbuckets
Copy link

It doesn't seem to work for me still using the pattern you established for shared modules.

Contents of /Scripts/Controllers/Root/Home/Index.ts:

var module = require("../Shared/child-module");
//reference to trick typescript into rendering a dependency
var x = module;

While typescript is happy with this reference compressor can't find the child-module. It thinks the child module is located at /Shared/child-module.js not /Scripts/Controllers/Root/Shared/child-module.js. Requirejs does understand the reference so I can still deploy but I can't use the auto compressor right now.

PS. I am running RequireJsNet version 2.1.52 off nuget and RequireJsNet.Compressior 2.1.36.

stefanprodan added a commit that referenced this issue Jul 15, 2016
Fix to issue #61 regarding relative file paths not resolving correctly
@stefanprodan
Copy link
Contributor

Fixed in release 2.2

@jayryemure
Copy link

jayryemure commented Sep 21, 2016

Having the same exact issue as @Spudbuckets but on version 2.2.3. It's not resolving paths with ../ properly.

Looking at the fix it only fixes paths with ./ and not ../ ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants